Traffic label transparent transmission plugin: optimize servicecomb server-side interception scenario #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilai23
reviewed
Sep 15, 2023
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1310 +/- ##
=============================================
+ Coverage 41.30% 42.49% +1.18%
- Complexity 3223 3313 +90
=============================================
Files 827 833 +6
Lines 18287 18467 +180
Branches 1991 2013 +22
=============================================
+ Hits 7554 7847 +293
+ Misses 9782 9645 -137
- Partials 951 975 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lilai23
reviewed
Sep 15, 2023
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Sep 15, 2023
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Outdated
Show resolved
Hide resolved
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Outdated
Show resolved
Hide resolved
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Outdated
Show resolved
Hide resolved
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Outdated
Show resolved
Hide resolved
sermant-plugins/sermant-tag-transmission/tag-transmission-service/pom.xml
Show resolved
Hide resolved
...c/main/resources/META-INF/services/com.huaweicloud.sermant.core.plugin.service.PluginService
Show resolved
Hide resolved
daizhenyu
force-pushed
the
develop-servicecomb-tag
branch
2 times, most recently
from
454542e
to
e7d5487
Compare
luanwenfei-venus
assigned luanwenfei-venus and daizhenyu and unassigned luanwenfei-venus
luanwenfei-venus
added
kind/enhancement
daizhenyu
force-pushed
the
develop-servicecomb-tag
branch
from
e7d5487
to
37c20c0
Compare
...om/huaweicloud/sermant/tag/transmission/interceptors/http/server/HttpServletInterceptor.java
Outdated
Show resolved
Hide resolved
daizhenyu
force-pushed
the
develop-servicecomb-tag
branch
from
37c20c0
to
2e4de3f
Compare
lilai23
approved these changes
Sep 16, 2023
luanwenfei-venus
approved these changes
Sep 16, 2023
kkf1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1244
[Modification content] Modified the servicecomb server-side interception point and used the servlet interception point to handle the servicecomb server-side scenario.
[Use case description] Not required
[Self-test situation] 1. Local static check passed